Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to port optimization of pooling renderer from react-rails #28

Closed
justin808 opened this issue Sep 20, 2015 · 0 comments
Closed

Need to port optimization of pooling renderer from react-rails #28

justin808 opened this issue Sep 20, 2015 · 0 comments
Labels
contributions: up for grabs!

Comments

@justin808
Copy link
Member

Use a connection pool for the js engine:

See options here: https://github.com/reactjs/react-rails#server-rendering

Here's the implementation:
https://github.com/reactjs/react-rails/blob/master/lib/react/server_rendering.rb
@shakacode shakacode mentioned this issue Sep 20, 2015
Closed
17 tasks
justin808 added a commit that referenced this issue Sep 27, 2015
@justin808
WIP for #28 -- not working
67ff26f
@justin808 justin808 mentioned this issue Sep 27, 2015
Merged
justin808 added a commit that referenced this issue Sep 28, 2015
@justin808
Merge pull request #41 from shakacode/connection-pool-server-rendering
1395ef6 
Fixes #28. Added pool for server renderers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributions: up for grabs!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@justin808