Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small formatting tweaks to use latest prettier #1249

Closed
wants to merge 3 commits into from

Conversation

justin808
Copy link
Member

@justin808 justin808 commented Mar 8, 2020

This change is Reviewable

Copy link
Contributor

@Judahmeek Judahmeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 106 of 106 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @justin808)


package-scripts.yml, line 33 at r1 (raw file):

      default:
        description: Run prettier-eslint on JS.
        #script: prettier "packages/**/*.@(js|jsx)" "spec/dummy/client/app/**/*.@(js|jsx)" "webpack.config.babel.js" "webpack/**/*.js" --write

space after # sign. Also why comment out these scripts instead of just removing them?


node_package/src/buildConsoleReplay.js, line 17 at r1 (raw file):

      let val;
      try {
        val = (typeof arg === 'string' || arg instanceof String) ? arg : JSON.stringify(arg);

Parentheses make this statement more readable, I believe


node_package/src/context.js, line 9 at r1 (raw file):

export default function context() {
  return ((typeof window !== 'undefined') && window) ||
    ((typeof global !== 'undefined') && global) ||

keep parentheses for readability?

@justin808
Copy link
Member Author

need to rebase on master!

@justin808
Copy link
Member Author

@Judahmeek are any of your prior comments still relevant? If not, let's close this PR.

@justin808
Copy link
Member Author

Done in #1261

@justin808 justin808 closed this Mar 28, 2020
@justin808 justin808 deleted the small-formatting-tweaks branch April 29, 2020 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants