Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Github actions #1326

Merged
merged 4 commits into from Sep 2, 2020
Merged

Improve Github actions #1326

merged 4 commits into from Sep 2, 2020

Conversation

Namilk18
Copy link
Contributor

@Namilk18 Namilk18 commented Sep 2, 2020 •
edited

  • Add the following missing rspec test tasks to Github actions workflow
  run_rspec:all_but_examples
  run_rspec:examples
  • Make the tasks run in parallel

This change is Reviewable

justin808
justin808 reviewed Sep 2, 2020
View reviewed changes
.github/workflows/main.yml
- name: Prep for CI
run: bundle exec rake prepare_for_ci
- name: Main CI
run: bundle exec rake run_rspec:all_dummy
run: bundle exec rake ${{ matrix.rake_task }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, this is really cool!

@justin808 justin808 merged commit cc44d70 into shakacode:master Sep 2, 2020
@justin808
Copy link
Member

Nice job @Zungong. Let's give this a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin808 justin808 justin808 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Namilk18 @justin808