Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to bundler 2.5.9 and commit top gemfile.lock #1619

Merged
merged 2 commits into from
May 17, 2024

Conversation

justin808
Copy link
Member

@justin808 justin808 commented May 16, 2024

Summary

2.5.3 lock of bundler causes these errors for me:

Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

current directory: /Users/justin/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/nio4r-2.5.8/ext/nio4r

/Users/justin/.asdf/installs/ruby/3.2.2/bin/ruby extconf.rb
checking for unistd.h... yes
checking for linux/aio_abi.h... no
checking for linux/io_uring.h... no
checking for sys/select.h... yes
checking for port_event_t in poll.h... no
checking for sys/epoll.h... no
checking for sys/event.h... yes
checking for sys/queue.h... yes
checking for port_event_t in port.h... no
checking for sys/resource.h... yes
creating Makefile

current directory: /Users/justin/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/nio4r-2.5.8/ext/nio4r
make DESTDIR= sitearchdir=./.gem.20240515-35487-luo5ud sitelibdir=./.gem.20240515-35487-luo5ud clean


This change is Reviewable

Summary by CodeRabbit

  • Chores
    • Updated Bundler version from 2.5.3 to 2.5.9 across all CI/CD configuration files for improved compatibility and potential bug fixes.
    • Removed specific Bundler version constraint in development dependencies for more flexible gem management.

Copy link

coderabbitai bot commented May 16, 2024

Walkthrough

The updates revolve around upgrading the Bundler version from 2.5.3 to 2.5.9 across various configuration and workflow files, ensuring compatibility and potential enhancements. The specific Bundler version constraint has been removed from Gemfile.development_dependencies.

Changes

Files Change Summary
.circleci/config.yml,
.github/workflows/examples.yml,
.github/workflows/lint-js-and-ruby.yml,
.github/workflows/main.yml,
.github/workflows/rspec-package-specs.yml
Updated Bundler version from 2.5.3 to 2.5.9 in Ruby setup steps and gem installation commands.
.travis.yml Updated Ruby version from 2.5.3 to 2.5.9.
Gemfile.development_dependencies Removed specific Bundler version constraint.
.gitignore Removed /Gemfile.lock from ignored files.

In the realm of code where changes play,
Bundler leaps from 2.5.3 to 2.5.9 today.
With gems aligned and tests refined,
Our codebase shines, the future defined.
Bugs beware, for we stand tall,
Our code sings, surpassing all. 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@Judahmeek Judahmeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justin808 justin808 changed the title Switch to bundler 2.5.9 Switch to bundler 2.5.9 and commit top gemfile.lock May 16, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 1295ce9 and 88600a7.
Files ignored due to path filters (1)
  • spec/dummy/Gemfile.lock is excluded by !**/*.lock
Files selected for processing (7)
  • .circleci/config.yml (1 hunks)
  • .github/workflows/examples.yml (2 hunks)
  • .github/workflows/lint-js-and-ruby.yml (2 hunks)
  • .github/workflows/main.yml (4 hunks)
  • .github/workflows/rspec-package-specs.yml (2 hunks)
  • .travis.yml (1 hunks)
  • Gemfile.development_dependencies (1 hunks)
Files skipped from review due to trivial changes (7)
  • .circleci/config.yml
  • .github/workflows/examples.yml
  • .github/workflows/lint-js-and-ruby.yml
  • .github/workflows/main.yml
  • .github/workflows/rspec-package-specs.yml
  • .travis.yml
  • Gemfile.development_dependencies

@@ -9,7 +9,6 @@ gem "sass-rails", "~> 6.0"
gem "uglifier"
gem "jquery-rails"
gem "puma", "~> 6.0"
gem "bundler", "2.5.3"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Judahmeek any need for this?

@@ -3,7 +3,7 @@ sudo: required
language: ruby

rvm:
- 2.5.3
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Judahmeek I don't think the .travis file is used any more.

@justin808
Copy link
Member Author

@Judahmeek if this works, I'll merge.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 88600a7 and 2345e3a.
Files ignored due to path filters (1)
  • Gemfile.lock is excluded by !**/*.lock
Files selected for processing (1)
  • .gitignore (1 hunks)
Files skipped from review due to trivial changes (1)
  • .gitignore

@justin808 justin808 merged commit 0c9fb65 into master May 17, 2024
16 checks passed
@justin808 justin808 deleted the justin808/bundler-v259 branch May 17, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants