Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache client/node_modules during heroku deploys #324

Closed
wants to merge 1 commit into from
Closed

cache client/node_modules during heroku deploys #324

wants to merge 1 commit into from

Conversation

modosc
Copy link

@modosc modosc commented Mar 10, 2016

without this heroku has to do a full npm install on every deploy - i guess this could be part of the heroku generators but it seemed like a lot more work to modify this file there than to just add this option here.


This change is Review on Reviewable

@justin808
Copy link
Member

@modosc This looks great. Can you please add a couple sentences to the heroku doc page.

Also, maybe this is more generic than heroku?

@justin808
Copy link
Member

Additionally, we have to see why the CI build does not pass with this.

@modosc
Copy link
Author

modosc commented Mar 14, 2016

seems like it failed for an unrelated reason:

W: Failed to fetch http://us.archive.ubuntu.com/ubuntu/dists/trusty-updates/main/source/Sources  Hash Sum mismatch
W: Failed to fetch http://us.archive.ubuntu.com/ubuntu/dists/trusty-updates/main/binary-amd64/Packages  Hash Sum mismatch
W: Failed to fetch http://us.archive.ubuntu.com/ubuntu/dists/trusty-updates/universe/binary-amd64/Packages  Hash Sum mismatch
E: Some index files failed to download. They have been ignored, or old ones used instead.

i can't seem to retrigger the build tho.

@justin808
Copy link
Member

@modosc any word on this one?

@modosc
Copy link
Author

modosc commented Mar 28, 2016

updated docs, let's see if ci is happy today.

@justin808
Copy link
Member

@modosc Please rebase on top of master to a single commit. Thanks.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.515% when pulling 7e78ae4 on modosc:patch-1 into e6fa8c4 on shakacode:master.

@@ -29,5 +29,6 @@
"url": "https://github.com/shakacode/react-webpack-rails-tutorial/issues"
},
"homepage": "https://github.com/shakacode/react-webpack-rails-tutorial",
"dependencies": {}
"dependencies": {},
"cacheDirectories": ["node_modules", "client/node_modules"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@modosc there should be no node_modules directory, right? Just client/node_modules.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's possible the app has one for some other reason (separate service, browserify integration, etc) and it's the heroku default if nothing else set so i figured it made sense to keep it just in case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.396% when pulling 284f0d2 on modosc:patch-1 into da9d525 on shakacode:master.

@justin808
Copy link
Member

@modosc can you please rebase on top of master. I want to merge this.

@justin808
Copy link
Member

@modosc I'm ready to merge your changes. However, we need to rebase on top of master, after squashing to one commit, and please include the changelog entry.

@justin808
Copy link
Member

@modosc Ping, Ping. I'm ready to merge your changes. However, we need to rebase on top of master, after squashing to one commit, and please include the changelog entry.

without this heroku has to do a full npm install on every deploy - i guess this could be part of the heroku generators but it seemed like a lot more work to modify this file there than to just add this option here.
@modosc
Copy link
Author

modosc commented May 9, 2016

@justin808 should be done?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.473% when pulling d1925a6 on modosc:patch-1 into 9491179 on shakacode:master.

@justin808
Copy link
Member

Manually merged in #415.

@justin808 justin808 closed this May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants