Fix bug in error messages printing #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #36.
| end | ||
| server_rendered_react_component_html |
…ias-bugfix-render-error-messages
|
@justin808 Done! |
|
I changed the strategy so that the place we put in the location of the messages is inside of the place where we polyfill on the server.
|
justin808
added a commit
that referenced
this pull request
Sep 27, 2015
* All server messages prefixed with [SERVER] * No prefixes on client messages or error handling * No warnings from React for server rendering console messages (previously got the warning for invalid whitespace for server rendering).
* All server messages prefixed with [SERVER] * No prefixes on client messages or error handling * No warnings from React for server rendering console messages (previously got the warning for invalid whitespace for server rendering).
justin808
force-pushed
the
josias-bugfix-render-error-messages
branch
from
7bdf506
to
dc0f921
Compare
justin808
added a commit
that referenced
this pull request
Sep 27, 2015
…ages Fix bug in error messages printing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #36.
@justin808 Can you review it?