[WIP] Refactor to pull js code into its own js file #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin808
force-pushed
the
refactor_to_split_js_helper
branch
from
48dcc1f
to
c4ce3df
Compare
WHY, WHY, WHY does execJS totally give a mysterious message when the JS expression ends with a single semicolon???
justin808
force-pushed
the
refactor_to_split_js_helper
branch
from
c4ce3df
to
8cf9987
Compare
|
Here's the result! Way cleaner client side generated code and way cleaner ruby!
|
|
Paired all the way with @samnang! Only thing that got us stuck was the execJS not wanting a semicolon at the end of the string!!! |
justin808
added a commit
that referenced
this pull request
Sep 29, 2015
[WIP] Refactor to pull js code into its own js file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.