Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test react-on-webpacker package #24

Closed
wants to merge 1 commit into from

Conversation

Judahmeek
Copy link
Contributor

@Judahmeek Judahmeek commented Nov 25, 2021

The babel preset needs to be refined, but the configuration swap works perfectly.


This change is Reviewable

Copy link
Member

@justin808 justin808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the comment, but so far looks good.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Judahmeek)


package.json, line 18 at r1 (raw file):

    "react-on-rails": "12.2.0",
    "react-on-webpacker": "^0.0.1-beta.0",
    "style-loader": "^3.3.1",

should the style-loader be a dependency of react-on-webpacker

@justin808
Copy link
Member

@Judahmeek @gscarv13 can you update this PR? I just updated https://github.com/rails/webpacker/pull/3224/files so we could have a demo of all the react stuff is in the package https://github.com/shakacode/react-on-webpacker

And we need some docs for that.

@justin808
Copy link
Member

@Judahmeek can we get this updated ASAP.

@justin808
Copy link
Member

@mrtnzlml @Judahmeek @tomdracz,

Is this PR still useful? Or should this:

  1. Be within shakapacker
  2. Be within documentation

@Judahmeek Judahmeek closed this Jan 13, 2023
@Judahmeek Judahmeek deleted the judahmeek/react_on_webpacker branch January 13, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants