Avoid check old webpack versions #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin808
reviewed
Aug 4, 2018
src/loader.js
Outdated
| Can't find sass resources in your config. | ||
| Make sure ${isModernWebpack ? 'loader.options.resources' : 'webpackConfig.sassResources'} exists. | ||
| `); | ||
| const error = new Error('Can\'t find sass resources in your config. Make sure loader.options.resources'); |
|
@david-ogalego any update? |
|
@alexfedoseev are you OK with this one? |
|
Yeah, totally. |
alex35mil
approved these changes
Oct 14, 2018
justin808
added a commit
that referenced
this pull request
Nov 6, 2018
This reverts commit 91d097e. This allows this commit to go into v2.0.0.
justin808
added a commit
that referenced
this pull request
Nov 6, 2018
This reverts commit 91d097e. This allows this commit to go into v2.0.0.
justin808
added a commit
that referenced
this pull request
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone wants to use older webpack versions, can download older versions of loader.
This change is