[max-len]: ignore import statements
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwise
reviewed
Nov 7, 2016
| ignoreRegExpLiterals: true | ||
| ignoreStrings: true | ||
| ignoreTemplateLiterals: true | ||
| ignorePattern: ^import\\s+ |
There was a problem hiding this comment.
I never knew that Airbnb had ignore strings and template literals on lol
Are we sure we want to do this instead of:
import {
foo,
bar,
} from './someLongName';I think it's important to see where things are coming from. In our internal project, we can use aliases to keep the from '' part short as well as refactoring our libs to be less nested.
There was a problem hiding this comment.
TBH I find the upper imports more readable than the lower ones.
There was a problem hiding this comment.
In that example, I agree with you that the top is better. I dunno I guess I'm okay with it then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@justin808 @robwise
This change is