Bump to depend on Airbnb 17.0.1 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignoring max-len for strings and template literals makes it too easy to include long lines in the project. However, if one is using prettier settings with eslint, max-len gets ingored anyway.
alex35mil
reviewed
Aug 13, 2018
| @@ -23,7 +23,7 @@ rules: | |||
|
|
|||
| # http://eslint.org/docs/rules/max-len | |||
| # https://github.com/airbnb/javascript/blob/master/packages/eslint-config-airbnb-base/rules/style.js#L128 | |||
| # Almost identical to airbnb's version, but adds ignore of `import` statements | |||
| # Almost identical to airbnb's version, but adds ignore of `import` statements and sets ignoreStrings: false | |||
There was a problem hiding this comment.
I think airbnb version is correct?
There was a problem hiding this comment.
This is Airbnb: https://github.com/airbnb/javascript/blob/17e0454672f784772c5f5ab052523a93229d9adf/packages/eslint-config-airbnb-base/rules/style.js#L195
If you prefer, I'll remove these for now.
// specify the maximum length of a line in your program
// https://eslint.org/docs/rules/max-len
'max-len': ['error', 100, 2, {
ignoreUrls: true,
ignoreComments: false,
ignoreRegExpLiterals: true,
ignoreStrings: true,
ignoreTemplateLiterals: true,
}],
| "eslint": "^4.19.1", | ||
| "eslint-plugin-import": "^2.12.0", | ||
| "eslint-plugin-jsx-a11y": "^6.0.3", | ||
| "eslint-plugin-react": "^7.9.1" |
There was a problem hiding this comment.
I copied these from Airbnb's one.
justin808
changed the title
|
@alexfedoseev I'm merging. We can do any review comments in a follow-on PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignoring max-len for strings and template literals makes it too easy
to include long lines in the project.
However, if one is using prettier settings with eslint, max-len gets
ingored anyway.
This change is