Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Three warnings #27

Closed
josvos opened this issue Aug 27, 2018 · 7 comments
Closed

Three warnings #27

josvos opened this issue Aug 27, 2018 · 7 comments

Comments

@josvos
Copy link

josvos commented Aug 27, 2018

The folliowing 3 (similar) warnings appear (Flutter dev 0.7.0, Dart 2.1.0-dev.1.0.flutter-69fce633b7, mqtt_client bd326b5):

[...]/lib/src/connectionhandling/mqtt_client_mqtt_normal_connection.dart:29:26: Warning: Can't return a value from a void function.
compiler message:         return completer.complete();
compiler message:                          ^
[...]/lib/src/connectionhandling/mqtt_client_mqtt_ws_connection.dart:48:26: Warning: Can't return a value from a void function.
compiler message:         return completer.complete();
compiler message:                          ^
[...]/lib/src/connectionhandling/mqtt_client_mqtt_secure_connection.dart:68:26: Warning: Can't return a value from a void function.
compiler message:         return completer.complete();
compiler message:                          ^
@shamblett
Copy link
Owner

OK, please test under the newly released 3.0.0 client, see issue 24

@josvos
Copy link
Author

josvos commented Aug 28, 2018

New test with Flutter dev 0.7.1, Dart version 2.1.0-dev.1.0.flutter-ccb16f7282, mqtt_client f58a2fd: 3 warnings stay the same.

benbehringer pushed a commit to benbehringer/mqtt_client that referenced this issue Aug 28, 2018
@shamblett
Copy link
Owner

OK, just complete the completer without returning, as in

completer.complete();

Works OK here

@josvos
Copy link
Author

josvos commented Sep 2, 2018

Did you change something? Which commit? Anyway, all warnings still are the same using git: https://github.com/shamblett/mqtt_client.git for dependency mqtt_client in pubspec.yaml.

@shamblett
Copy link
Owner

Nothing changed, just waiting to see if one of the flutter guys can test the above change, if it works I'll re-publish.

@shamblett
Copy link
Owner

Trial fix incorporated into release 3.1.0, please re-test

@josvos
Copy link
Author

josvos commented Sep 6, 2018

Works fine now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants