Github workflow installer package not producing desired application icon

[JimT787]

I have an 'icon.png' in the same root folder with 'package.json' and it is 512x512 as recommended in the jDeploy documentation.

The installer package installs properly, but only produces the generic icon on the desktop.

I included a screenshot of the Github code page to demonstrate this. This is an installer package produced with a Github workflow and I tried the installer on Mac and Windows with the same effect--generic icon.

Maybe I'm doing something wrong? I did not try to produce an installable package using the npm method.

[shannah]

Are you downloading it from the jdeploy download page or the github release page?

[JimT787]

Both if I’m understanding the question and meant to say this in the original issue notes.

The private repo produces the bundles nicely in the public repo. I tried using the installation bundle on that Github release page AND also navigated to the download page and tried that. Neither of them produces an icon although both install and run the program nicely.

The bundles have different filenames--the github release bundle always ends with "_25BD.zip" and the download page bundle is "_25BE.zip"

Between tests, I use the uninstall routine, then go the ‘.jdeploy’ directory and delete all the directories with the app and finally delete the icon from the desktop to start fresh…

Hope that helps,

Jim

Also, forgot to attach image of code page on private repo showing icon.png in same directory as package.json:

[shannah]

I have a few ideas on what is going on here, but probably won't be able to look at this until next weekend.

[JimT787]

No worries—thank you for the update! Jim From: Steve Hannah ***@***.***> Sent: Saturday, February 25, 2023 10:13 AM To: shannah/jdeploy ***@***.***> Cc: Jim Tatro ***@***.***>; Author ***@***.***> Subject: Re: [shannah/jdeploy] Github workflow installer package not producing desired application icon (Issue #97) I have a few ideas on what is going on here, but probably won't be able to look at this until next weekend. — Reply to this email directly, view it on GitHub <#97 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AXSAQIBHRKU523V7EXLYC33WZIVRLANCNFSM6AAAAAAVCROVEE> . You are receiving this because you authored the thread. <https://github.com/notifications/beacon/AXSAQIBIG4OXV5XUGSR2XJTWZIVRLA5CNFSM6AAAAAAVCROVEGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSWEM7ZC.gif> Message ID: ***@***.*** ***@***.***> >

[pkriens]

I am faced withe same problem with some additional missing pieces:

• Version is not visible
• No installer splash
• No icon

This is the action that build it: https://github.com/AlloyTools/org.alloytools.alloy/actions/runs/5189366305/jobs/9354269825

This is the created release: https://github.com/AlloyTools/org.alloytools.alloy/releases/tag/release

About:

It would be quite impressive if this all works. Although I am a bit puzzled how it works security wise ...

[pkriens]

@shannah I need to make a decision to use jdeploy for an open source product. A friend of mine had good experiences but I noticed he used the npm deploy model. I have a rather strong preference for the github route. Could you indicate that this should all work on github as well or that the npm route for now would be more certain? I need to make a decision in the next week.

[shannahcloudbeds]

@pkriens Sorry, just noticed this message now.

The github support is more recent. npm is simpler, and, I suppose, more proven by the fact that I have been using it since v1.0, and github is just since 4.0. That said, the GitHub support provides a few nice things, like the ability to have branch-based releases, and turn-key integration with github actions for releases.

[electronstudio]

I have same issue as @JimT787 and @pkriens . Was a solution ever found?

[shannah]

@electronstudio Can you share a link to your repo (if available) or just your download page (if repo not available)? I'd like to take a look at what is going on there.

[electronstudio]

thanks, i'll email it to you

[shannah]

This issue is fixed now. If you run the installer again, it should pick up your latest icon. and splash screen.