Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Power Regulation Infrastructure #224

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Conversation

gsgall
Copy link
Collaborator

@gsgall gsgall commented Dec 16, 2023

closes #222 and enables the users to hold the power deposition into the plasma at a constant value by iteratively updating the applied voltage of a boundary condition

This PR only holds the infrastructure. An issue will be opened to add an action and tutorial for this feature as well to make sure users can easily utilize this since the combination of each of these post processors and auxkernels may not be immediately obvious.

@moosebuild
Copy link
Collaborator

moosebuild commented Dec 16, 2023

Job Documentation on 6b38197 wanted to post the following:

View the site here

This comment will be updated on new commits.

@csdechant
Copy link
Collaborator

@gsgall I just saw this PR and notice no one was assigned to review it. Is the PR ready for review, or are you still working on it?

@gsgall
Copy link
Collaborator Author

gsgall commented Dec 18, 2023

@csdechant This PR is ready for review!

@csdechant csdechant self-requested a review December 18, 2023 21:26
Copy link
Collaborator

@csdechant csdechant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsgall Overall, good job with the PR. I did have some questions and recommends on the structure of some of the documentation. I also have some questions on the tests that might result in re-golding some file. One of my bigger questions is did you intended on including an Action for power regulation in this PR, or is that future plans?

moose Outdated Show resolved Hide resolved
@cticenhour
Copy link
Member

@gsgall A MOOSE submodule update sneaked in with commit 82b0b78. Was this intentional?

@gsgall
Copy link
Collaborator Author

gsgall commented Jan 11, 2024

@gsgall A MOOSE submodule update sneaked in with commit 82b0b78. Was this intentional?

No that snuck in there when I was merging locally to resolve a conflict I had in one of the doc files for some reason. I’ll take care of this when I get to the office.

moose Outdated Show resolved Hide resolved
@csdechant
Copy link
Collaborator

@gsgall Everything looks good, just very minor things to address. Also, there are a lot of commits here. I would recommend to squashing these commits.

@gsgall
Copy link
Collaborator Author

gsgall commented Feb 4, 2024

@csdechant I squashed the commits I think everything should be good to go!

Co-authored-by: Corey DeChant <37221357+csdechant@users.noreply.github.com>
@gsgall
Copy link
Collaborator Author

gsgall commented Apr 3, 2024

@csdechant Is there anything else that needs to be done for this?

Copy link
Collaborator

@csdechant csdechant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsgall Sorry for the delay in reviewing. The only thing that needs to be change is that ## Example Input File Syntax needs a new line between the header and body text. Everything else looks good.

Co-authored-by: Corey DeChant <37221357+csdechant@users.noreply.github.com>
@gsgall
Copy link
Collaborator Author

gsgall commented Apr 12, 2024

@gsgall Sorry for the delay in reviewing. The only thing that needs to be change is that ## Example Input File Syntax needs a new line between the header and body text. Everything else looks good.

@csdechant done!

@csdechant csdechant merged commit e54bb42 into shannon-lab:devel Apr 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Power Regulation Infrastructure
4 participants