New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS: Remove boston dataset from the README #3200
Conversation
Tests are failing due to calls to |
Never mind, I think I've fixed |
Looks like this is a duplicate of #3156 |
I've added a commit to update the mpl image baselines. We can revert this if references to the legacy |
There's a discrepancy between how my setup generates the baselines and GitHub Actions. I'll need to alter my setup so that I produce the same outputs as GitHub Actions. |
3b91aad
to
acfeef3
Compare
I've removed the changes to SHAP's plotting functionality. I think these changes should be postponed pending the wider plotting API change proposed for 0.44 by #2363. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @dsgibbons one minor comment, any reason why we're not removing the boston_xxx.png
files from docs/artwork
?
Good point, removed! |
Overview
Closes dsgibbons#8 and resolves the issues noted in dsgibbons#8 (comment)
Related to #2322
Updating the README required the following additional changes:
shap
HTML to PNG? I've tried several different HTML to PNG converters, but I keep getting ashap
error saying JS needs initialising.Checklist