New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK11 Unit Tests Fix #48
Conversation
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
import static org.mockito.Matchers.anyString; | ||
//import static org.mockito.Matchers.anyLong; | ||
//import static org.mockito.Matchers.anyObject; | ||
//import static org.mockito.Matchers.anyString; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pearl1594 remove any dead code and commented code.
@Pearl1594 overall lgtm, I'll do a thorough review and tests tomorrow. The only outstanding issue is that of removing dead and commented code. |
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Looks like squash merge changed the authorship I'll fix it manually on apache#3601 so @Pearl1594 gets commit in her name for her changes |
Fix unit tests by using newer mocking approaches, leniency and fixing xml/mocks. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
From 4.9.3.0 to 4.10.0.0 storing of tags for storage pools was changed from cloud.storage_pool_details to cloud.storage_pool_tags. Up-port in #47 missed this and was using tag retrieval from the old table. https://github.com/apache/cloudstack/blob/4.10.0.0/setup/db/db/schema-4930to41000.sql#L139-L151 Unit tests replaced from https://github.com/apache/cloudstack/blob/4.12.0.0/server/src/test/java/com/cloud/storage/VolumeApiServiceImplTest.java
No description provided.