Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Es2018 take two impl #250

Merged
merged 29 commits into from
Jun 18, 2019
Merged

Es2018 take two impl #250

merged 29 commits into from
Jun 18, 2019

Conversation

Shilpi3
Copy link
Contributor

@Shilpi3 Shilpi3 commented May 28, 2019 •
edited
Loading

This PR adds the es2018 features

  • DotAll flag for regex
  • Object Rest
  • Object Spread

@Shilpi3 Shilpi3 changed the base branch from es2017 to es2018 May 29, 2019 04:17
@Shilpi3 Shilpi3 requested a review from Protryon May 29, 2019 16:42
@Protryon Protryon mentioned this pull request May 29, 2019
Merged
@Shilpi3 Shilpi3 changed the base branch from es2018 to es2017 May 29, 2019 17:05
@Shilpi3 Shilpi3 changed the base branch from es2017 to es2018 May 29, 2019 17:18
Shilpi3 and others added 23 commits May 29, 2019 10:58
@Shilpi3
Changed to openjdk
1728821
@Shilpi3
Removing openjdk11
3c05c4f
@Shilpi3
update submodules
d775bc3
@Shilpi3
regenerate sources and update types
4c451a3
@Shilpi3
copy tests from es2018-impl
907d8c9
@Shilpi3
commit generated-sources
c1d54cb
@Shilpi3
bugfix shift-spec
8eec3b6
@Shilpi3
allow generators when parsing async functions
7d1ec6a
@Shilpi3
parse for-await statements
9a987ba
@Shilpi3
better error messages and transformDestructuring for spread
1157bc8
@Shilpi3
parse object spread
bcb03c3
@Shilpi3
fix for-await parsing
d1d96d8
@Shilpi3
move test
018c9fc
@Shilpi3
object spread bindings, async generator methods
5d5daf3
@Shilpi3
missing async generator case
49800f6
@Shilpi3
add yield to strict mode reserved words
d8c9402
@Shilpi3
include spread properties
824066c
@Shilpi3
Fixed test messages
75fab01
@Shilpi3
inline parseArguments
1a24627
@Shilpi3
refactor parseArgumentList
4ef85f4
@Shilpi3
refactor parseArgumentList more
21d40d8
@Shilpi3
support parsing ambiguious argument lists
1f409b5
@Shilpi3
convert object rest in targetToBinding
39d6dec
@bakkot
Copy link
Member

bakkot commented May 30, 2019

Need to delete generated-sources/main/java/com/shapesecurity/shift/.DS_Store

bakkot
bakkot approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. @michaelficarra what do you think?

@Protryon Protryon mentioned this pull request Jun 3, 2019
Closed
@bakkot bakkot merged commit 9d05dfc into shapesecurity:es2018 Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelficarra michaelficarra michaelficarra left review comments

@bakkot bakkot bakkot approved these changes

@Protryon Protryon Protryon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shilpi3 @bakkot @michaelficarra @Protryon