Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #304: validate exponentiation expression LHSs #306

Merged
merged 1 commit into from
Oct 21, 2016
Merged

fixes #304: validate exponentiation expression LHSs #306

merged 1 commit into from
Oct 21, 2016

Conversation

michaelficarra
Copy link
Member

@michaelficarra michaelficarra commented Oct 20, 2016 •
edited
Loading

Fixes #304.

We should open a PR to test262-parser-tests adding these tests.

@bakkot
Copy link
Member

bakkot commented Oct 20, 2016

This rejects (-a) ** b, which should also be added as a test.

@bakkot
Copy link
Member

bakkot commented Oct 20, 2016

Because () => a ** b parses as () => (a ** b), I'm pretty sure you can get away with storing the first token of the LHS, and only throwing if the first token was not (. But it's kind of a hack.

@michaelficarra
Copy link
Member Author

Oh yeah. Whoops.

@bakkot
Copy link
Member

bakkot commented Oct 21, 2016

Fixed and added test.

@michaelficarra michaelficarra merged commit ce88859 into es2016 Oct 21, 2016
@michaelficarra michaelficarra deleted the GH-304 branch October 21, 2016 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bakkot bakkot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelficarra @bakkot