Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

CoinCap MarketService Implementation #281

Closed
0xean opened this issue Dec 10, 2021 · 11 comments · Fixed by #286
Closed

CoinCap MarketService Implementation #281

0xean opened this issue Dec 10, 2021 · 11 comments · Fixed by #286
Labels
bounty Issue is posted on dework.xyz as a bounty good first issue Good for newcomers released

Comments

@0xean
Copy link
Contributor

0xean commented Dec 10, 2021

Background

Our new web application (app.shapeshift.com) relies on a MarketService for its market data. Currently, we have a single implementation of this MarketService abstraction using coingecko.

We would like to create a second implementation that uses https://coincap.io as the backend.

The interface to implement can be found in here the lib repo:

export interface MarketService {

And this is the Coingecko implementation being instantiated as the sole implementation:

const MarketProviders = [new CoinGeckoMarketService()]

Finally this is the Coingecko implementation itself which can be used as a reference:
https://github.com/shapeshift/lib/tree/main/packages/market-service/src/coingecko

Acceptance Criteria

  • Create a new implementation of the MarketService interface for Coincap
  • Implement full test suite for the added functionality modeled after coingecko.test.ts

References

@natven natven changed the title @ADAM WILL DO THIS BEFORE 4PM MT CoinCap MarketService Implementation Dec 10, 2021
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 750.0 FOX (489.77 USD @ $0.65/FOX) attached to it as part of the ShapeShift fund.

@0xean 0xean added bounty Issue is posted on dework.xyz as a bounty good first issue Good for newcomers labels Dec 13, 2021
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 264 years, 11 months from now.
Please review their action plans below:

1) zerquix18 has been approved to start work.

Instructions are clear. I'll add a separate provider for the CMC as clean as possible, with tests included.
2) godv2 has applied to start work (Funders only: approve worker | reject worker).

i am backend developer mostly working on go, js/ts, rust projects, new in gitcoin platform. i want to apply for this issue. looks like wrapper around the api. since there is test for conformance this should be easy.
waiting for reply, thanks

Learn more on the Gitcoin Issue Details page.

@0xean
Copy link
Contributor Author

0xean commented Dec 14, 2021

@Zerquix18 - just to confim this is for coincap.io not CMC :)

@Zerquix18
Copy link
Contributor

@0xean Thanks for clarifying! I misread

@0xMillz
Copy link

0xMillz commented Dec 15, 2021

I'm interested in this bounty as well if you end up needing a backup

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 750.0 FOX (482.42 USD @ $0.64/FOX) has been submitted by:


@0xean 0xean linked a pull request Dec 15, 2021 that will close this issue
0xdef1cafe pushed a commit that referenced this issue Dec 17, 2021
* Add coincap

* add coincap adapter

* remove tokenId check

* readd tokenId check

* remove scripts to generate marketcap data

* apply linter fixes
shapeshift-ci-bot pushed a commit that referenced this issue Dec 17, 2021
# [@shapeshiftoss/caip-v1.7.0](https://github.com/shapeshift/lib/compare/@shapeshiftoss/caip-v1.6.1...@shapeshiftoss/caip-v1.7.0) (2021-12-17)

### Features

* implement coincap market service (fixes [#281](#281)) ([#286](#286)) ([2159a00](2159a00))
@shapeshift-ci-bot
Copy link
Member

🎉 This issue has been resolved in version @shapeshiftoss/caip-v1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

shapeshift-ci-bot pushed a commit that referenced this issue Dec 17, 2021
# [@shapeshiftoss/market-service-v1.6.0](https://github.com/shapeshift/lib/compare/@shapeshiftoss/market-service-v1.5.2...@shapeshiftoss/market-service-v1.6.0) (2021-12-17)

### Features

* implement coincap market service (fixes [#281](#281)) ([#286](#286)) ([2159a00](2159a00))
@shapeshift-ci-bot
Copy link
Member

🎉 This issue has been resolved in version @shapeshiftoss/market-service-v1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@0xean
Copy link
Contributor Author

0xean commented Dec 17, 2021

@Zerquix18 - thank you so much for the PR - Payout and tip on its way to you.

Please hop in our discord - https://discord.gg/shapeshift - and say hello, would love to have you stick around for another bounty.

@0xean
Copy link
Contributor Author

0xean commented Dec 20, 2021

Original TX failed - updating with most recent https://etherscan.io/tx/0x5bd99ff4a6caacca424b25132743fdb221456d6dfc75151e76348b3f09e4aba6

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 750.0 FOX (420.61 USD @ $0.56/FOX) attached to this issue has been approved & issued to @Zerquix18.

sdmg15 pushed a commit to sdmg15/lib that referenced this issue Jan 6, 2022
…hift#286)

* Add coincap

* add coincap adapter

* remove tokenId check

* readd tokenId check

* remove scripts to generate marketcap data

* apply linter fixes
sdmg15 pushed a commit to sdmg15/lib that referenced this issue Jan 6, 2022
sdmg15 pushed a commit to sdmg15/lib that referenced this issue Jan 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bounty Issue is posted on dework.xyz as a bounty good first issue Good for newcomers released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants