-
Notifications
You must be signed in to change notification settings - Fork 54
CoinCap MarketService Implementation #281
Comments
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 750.0 FOX (489.77 USD @ $0.65/FOX) attached to it as part of the ShapeShift fund.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 264 years, 11 months from now. 1) zerquix18 has been approved to start work. Instructions are clear. I'll add a separate provider for the CMC as clean as possible, with tests included. i am backend developer mostly working on go, js/ts, rust projects, new in gitcoin platform. i want to apply for this issue. looks like wrapper around the api. since there is test for conformance this should be easy. Learn more on the Gitcoin Issue Details page. |
@Zerquix18 - just to confim this is for coincap.io not CMC :) |
@0xean Thanks for clarifying! I misread |
I'm interested in this bounty as well if you end up needing a backup |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 750.0 FOX (482.42 USD @ $0.64/FOX) has been submitted by:
|
🎉 This issue has been resolved in version @shapeshiftoss/caip-v1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version @shapeshiftoss/market-service-v1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@Zerquix18 - thank you so much for the PR - Payout and tip on its way to you. Please hop in our discord - https://discord.gg/shapeshift - and say hello, would love to have you stick around for another bounty. |
Original TX failed - updating with most recent https://etherscan.io/tx/0x5bd99ff4a6caacca424b25132743fdb221456d6dfc75151e76348b3f09e4aba6 |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done The funding of 750.0 FOX (420.61 USD @ $0.56/FOX) attached to this issue has been approved & issued to @Zerquix18.
|
…hift#286) * Add coincap * add coincap adapter * remove tokenId check * readd tokenId check * remove scripts to generate marketcap data * apply linter fixes
# [@shapeshiftoss/caip-v1.7.0](https://github.com/shapeshift/lib/compare/@shapeshiftoss/caip-v1.6.1...@shapeshiftoss/caip-v1.7.0) (2021-12-17) ### Features * implement coincap market service (fixes [shapeshift#281](shapeshift#281)) ([shapeshift#286](shapeshift#286)) ([2159a00](shapeshift@2159a00))
# [@shapeshiftoss/market-service-v1.6.0](https://github.com/shapeshift/lib/compare/@shapeshiftoss/market-service-v1.5.2...@shapeshiftoss/market-service-v1.6.0) (2021-12-17) ### Features * implement coincap market service (fixes [shapeshift#281](shapeshift#281)) ([shapeshift#286](shapeshift#286)) ([2159a00](shapeshift@2159a00))
Background
Our new web application (app.shapeshift.com) relies on a MarketService for its market data. Currently, we have a single implementation of this MarketService abstraction using coingecko.
We would like to create a second implementation that uses https://coincap.io as the backend.
The interface to implement can be found in here the lib repo:
lib/packages/market-service/src/api.ts
Line 3 in b9d28eb
And this is the Coingecko implementation being instantiated as the sole implementation:
lib/packages/market-service/src/index.ts
Line 15 in b9d28eb
Finally this is the Coingecko implementation itself which can be used as a reference:
https://github.com/shapeshift/lib/tree/main/packages/market-service/src/coingecko
Acceptance Criteria
References
The text was updated successfully, but these errors were encountered: