feat: improve mm impersonator checks

[gomesalexandre]

Description

Adds a "definitive" (for now at least) list of MM impersonators and explicitly checks against them with a new checkIsMetaMaskImpersonator method in addition to our checkIsMetaMask method, to avoid impersonators being detected as MM.

Pull Request Type

• 🐛 Bug fix (Non-breaking Change: Fixes an issue)
• 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
• 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

• losely relates to Cowswap trade on Gnosis via Rabby does not work #5138

Risk

• MM could be wrongly detected as an impersonator and the snap modal may not be displayed for it, test according to the testing steps

Testing

• When connecting Rabby wallet (or any of the wallets in the METAMASK_IMPERSONATORS e.g Zerion wallet extension), the MM snaps modal doesn't show up
• When connecting actual MM, the MM snaps modal shows up
• Connecting previously not working MM impersonators (e.g Zerion) is now possible. Note, this is not a magic solution that will make any impersonator work as they all have their ramifications. Tested Zerion is now happy after feat: gracefully handle mm impersonators hdwallet#657, but if other impersonators are still not working, this will need to be tackled as a per-wallet basis.

Engineering

• ☝🏽

Operations

• ☝🏽

Screenshots (if applicable)

MM snaps modal only shows up for actual MM

• Develop 🚫 - modal shows up for MM, but also impersonators

• This diff ✅ - modal shows up only for actual MM

[gomesalexandre]

Current dependencies on/for this PR:

• develop
  • PR feat: improve mm impersonator checks #5896 👈

This stack of pull requests is managed by Graphite.

[0xApotheosis]

I'm getting a snaps install prompt with using actual metamask, but not when using Brave Wallet 👌