Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to create-react-app 5 #604

Merged
merged 4 commits into from
Dec 23, 2021
Merged

chore: upgrade to create-react-app 5 #604

merged 4 commits into from
Dec 23, 2021

Conversation

mrnerdhair
Copy link
Contributor

@mrnerdhair mrnerdhair commented Dec 21, 2021

Description

Good news: closes #589, closes #605, closes #549

Bad news: Webpack 5 dropped support for node polyfills; note facebook/create-react-app#11756, which basically says "whatever, not our problem" about it. Now we have to provide our own. Webpack can detect all the modules that need to be included, but ops testing will be needed to discover if any errors are triggered by modules which are using any more Node globals.

Notice

Before submitting a pull request, please make sure you have answered the following:

  • Have you followed the guidelines in our Contributing guide?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Do all new and existing tests pass? Does the linter pass?

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 21, 2021

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 90b144d
Status: ✅  Deploy successful!
Preview URL: https://6d571025.web-29e.pages.dev

View logs

@mrnerdhair mrnerdhair marked this pull request as ready for review December 21, 2021 22:31
@mrnerdhair mrnerdhair requested a review from a team as a code owner December 21, 2021 22:31
@mrnerdhair
Copy link
Contributor Author

Note the patch-package stuff can go once timarney/react-app-rewired#589 is merged, and it looks like that'll happen quite soon.

@mrnerdhair
Copy link
Contributor Author

There are a few new linter rules; testing-library/no-unnecessary-act says to remove await act() wrappers from various tests, but there are three that hang if not wrapped. @toshiSat, any feedback on whether to remove all the wrappers that don't break the tests, or to disable the eslint rule each time?

@mrnerdhair
Copy link
Contributor Author

timarney/react-app-rewired#589 was merged this morning, and I've updated and dropped the interim patch-package hack.

@mrnerdhair mrnerdhair linked an issue Dec 22, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants