-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to create-react-app 5 #604
Conversation
Deploying with Cloudflare Pages
|
8759233
to
66ff5e3
Compare
Note the patch-package stuff can go once timarney/react-app-rewired#589 is merged, and it looks like that'll happen quite soon. |
There are a few new linter rules; |
68c9b40
to
36f223c
Compare
timarney/react-app-rewired#589 was merged this morning, and I've updated and dropped the interim patch-package hack. |
Description
Good news: closes #589, closes #605, closes #549
Bad news: Webpack 5 dropped support for node polyfills; note facebook/create-react-app#11756, which basically says "whatever, not our problem" about it. Now we have to provide our own. Webpack can detect all the modules that need to be included, but ops testing will be needed to discover if any errors are triggered by modules which are using any more Node globals.
Notice
Before submitting a pull request, please make sure you have answered the following:
Pull Request Type