Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: thorchain evm transaction parsing #6085

Merged
merged 15 commits into from
Jan 26, 2024
Merged

Conversation

kaladinlight
Copy link
Contributor

@kaladinlight kaladinlight commented Jan 25, 2024

Description

Adds thorchain transaction parsing for all supported evm chains

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #6020

Risk

High Risk PRs Require 2 approvals

Low - isolated to evm tx parsers. make sure evm transactions are being displayed correctly

Testing

Ensure the transaction row is displaying the correct type and information for the following thorchain types on evm chains (both native asset and tokens):

  • Swap Request (Standard and Streaming)
  • Swap Received (Standard and Streaming)
  • Swap Refund (Standard and Streaming)
  • Liquidity Deposit (Savers and LP when we can test)
  • Liquidity Refund (Savers and LP when we can test)
  • Liquidity Withdraw Request (Savers and LP when we can test)
  • Liquidity Withdraw Received (Savers and LP when we can test)
  • Loan Open
  • Loan Open Refund
  • Loan Repayment
  • Loan Repayment Refund
  • Loan Collateral Received
  • Swap Request Longtail (no associated tag unless we would like that @reallybeard)

Also worth spot checking evm transaction history to validate everything else is still being displayed as expected.

Engineering

☝️

Operations

☝️

Screenshots (if applicable)

Swaps
image
image
image
image
image

Streaming Swaps
image
image

image
image
image

Savers
image
image
image
image

LP
image
image
image

Loan
image
image
image
image

Longtail
image
image

@kaladinlight kaladinlight marked this pull request as ready for review January 26, 2024 00:18
@kaladinlight kaladinlight requested a review from a team as a code owner January 26, 2024 00:18
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First conceptual pass, looking excellent so far - haven't noticed anything odd here.
Functional pass up next!

Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with a subset of the added parsing which I have available, because of testing funds - deferring to @shapeshift/operations for the green light on this

LP Deposit

image

LP Withdraw requested

image

LP Withdraw Received

image

Swap

image

Savers withdraw request and withdraw received

  • Note that withdraw request isn't parsed obviously since it's a send vs. contract call
image

Savers EVM token deposit

image

Loan Collateral Received

image image

Loan Open

image

Long-tail

image image

@kaladinlight kaladinlight merged commit 23f95f7 into develop Jan 26, 2024
3 checks passed
@kaladinlight kaladinlight deleted the thorchain-evm-tx-parsing branch January 26, 2024 15:48
@MBMaria
Copy link

MBMaria commented Jan 29, 2024

Non Blocker:

  • Still getting a couple transactions listed as "Transaction" in the Activity tab

image
image

@MBMaria
Copy link

MBMaria commented Jan 29, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thorchain tx parsing (EVM)
3 participants