Add PRISMA visual type view and JS stub #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shapiromatron
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Looks good - I did a major refactoring to use the full JS form lifecycle, instead of the django template based once you originally implemented, this is what we'll need for this diagram since it will be heavily interactive. It took a look of code, a lot of it redundant with the exploratory heatmap JS, so it may be ripe for refactoring in the future.
That said, this PR will be a good template for how to create a new JS summary figure.
| @@ -33,6 +33,7 @@ class Migration(migrations.Migration): | |||
| (6, "exploratory heatmap"), | |||
| (7, "plotly"), | |||
| (8, "static image"), | |||
| (9, "PRISMA"), | |||
There was a problem hiding this comment.
I had to update a migration since the database choices were altered; I didn't have to create one since this doesn't change the database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the building blocks for the PRISMA visual type. Adds a JS view for the PRISMA form that loads when it is selected from the dropdown list, which is a stub for future development of the form.