Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove copy across study across assessment #767

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Conversation

shapiromatron
Copy link
Owner

@shapiromatron shapiromatron commented Jan 13, 2023

Remove old copy_across_assessments code - it was untested and likely had many errors. If rewritten in the future, this may be useful as a resources. However:

  • instead of putting into the models.py, move to a services style structure?
  • consider clone(parent=...) as a different structure?
  • build some sort of non-dict data structure to properly store the state changes
  • unit tests for each component!

@shapiromatron shapiromatron changed the title remove all copy across assessments code remove copy across study across assessment Jan 14, 2023
@shapiromatron shapiromatron marked this pull request as ready for review January 14, 2023 00:55
@shapiromatron shapiromatron requested review from caseyhans and munnsmunns and removed request for caseyhans January 17, 2023 19:50
Copy link
Collaborator

@munnsmunns munnsmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge!

@shapiromatron shapiromatron merged commit 8ef12a3 into main Jan 17, 2023
@shapiromatron shapiromatron deleted the no-copy-assessment branch January 17, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants