♻ Throw error for pending ops on hard rollback #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawidreedsy
force-pushed
the
fix-sharedb-error-submit-err
branch
5 times, most recently
from
066ef69
to
4ae9c50
Compare
dawidreedsy
force-pushed
the
fix-sharedb-error-submit-err
branch
from
4ae9c50
to
96ee0ce
Compare
|
From discussion between @dawidreedsy, @alecgibson, Edmond, and me: For soft-rejecting an op:
That behavior should apply to edit, create, and del. |
dawidreedsy
force-pushed
the
fix-sharedb-error-submit-err
branch
3 times, most recently
from
92adad5
to
16ae32e
Compare
dawidreedsy
changed the title
dawidreedsy
force-pushed
the
fix-sharedb-error-submit-err
branch
from
16ae32e
to
9428deb
Compare
Our current flow for handling the rollback swallows some errors and discards pending ops. 1. Whenever we do hard rollback and fetch for hard rollback fails we should throw the error so that user is informed that something really wrong happen. 2. Whenever we preform the hard rollback and we have some pending ops and the `ERR_OP_PENDING_OP_SUBMIT_REJECTED` error is thrown we should soft reject, as this error is meant for the user to reject some of the ops from submition to DB, however we should throw for all the pending ops s the pending ops would be otherwise just discarded. This way we at least allow user to handle the error 3. For the soft rollback we just resolve for this error and allow pending ops to be submitted to the server.
dawidreedsy
force-pushed
the
fix-sharedb-error-submit-err
branch
from
9428deb
to
5a3bbfd
Compare
alecgibson
reviewed
Oct 10, 2023
| var doc = connection.get('dogs', 'fido'); | ||
| doc.preventCompose = true; | ||
|
|
||
| doc.create({age: 3}); |
There was a problem hiding this comment.
Cannot really as we check create without callback
alecgibson
reviewed
Oct 10, 2023
ericyhwang
reviewed
Oct 10, 2023
alecgibson
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current flow for handling the rollback swallows some errors and discards pending ops.
ERR_OP_PENDING_OP_SUBMIT_REJECTEDerror is thrown we should soft reject, as this error is meant for the user to reject some of the ops from submition to DB, however we should throw for all the pending ops s the pending ops would be otherwise just discarded. This way we at least allow user to handle the errorThis PR is extracted from: