Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻ Throw error for pending ops on hard rollback #626

Merged
merged 7 commits into from
Oct 10, 2023
Merged

♻ Throw error for pending ops on hard rollback #626

merged 7 commits into from
Oct 10, 2023

Commits on Oct 10, 2023

  1. ♻ Throw error for pending ops on hard rollback 

    Our current flow for handling the rollback swallows some errors and discards pending ops.
1. Whenever we do hard rollback and fetch for hard rollback fails we should throw the error so that user
   is informed that something really wrong happen.
2. Whenever we preform the hard rollback and we have some pending ops
   and the `ERR_OP_PENDING_OP_SUBMIT_REJECTED` error is thrown we should
   soft reject, as this error is meant for the user to reject some of
   the ops from submition to DB, however we should throw for all the
   pending ops s the pending ops would be otherwise just discarded. This
   way we at least allow user to handle the error
3. For the soft rollback we just resolve for this error and allow
   pending ops to be submitted to the server.
    @Dawidpol
    Dawidpol committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    5a3bbfd View commit details
    Browse the repository at this point in the history

  2. Apply alec comments

    @Dawidpol
    Dawidpol committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    b8b7a1f View commit details
    Browse the repository at this point in the history

  3. Invert if in hard rollback

    @Dawidpol
    Dawidpol committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    16794f9 View commit details
    Browse the repository at this point in the history

  4. Change error message

    @Dawidpol
    Dawidpol committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    057cb26 View commit details
    Browse the repository at this point in the history

  5. Add hardrollback fetch error

    @Dawidpol
    Dawidpol committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    0546f99 View commit details
    Browse the repository at this point in the history

  6. Change to unshift

    @Dawidpol
    Dawidpol committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    28aafc6 View commit details
    Browse the repository at this point in the history

  7. Fix tests

    @Dawidpol
    Dawidpol committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    a52426e View commit details
    Browse the repository at this point in the history