Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we have overrides? #58

Closed
millsp opened this issue Aug 16, 2019 · 2 comments
Closed

Can we have overrides? #58

millsp opened this issue Aug 16, 2019 · 2 comments
Labels
core Issues related only for sharec core logic enhancement New feature or request

Comments

@millsp
Copy link

millsp commented Aug 16, 2019

Hi @lamartire, first of all bravo for this package. I also had the idea to simplify the build/setup process, but I couldn't have done it simpler than this. You had a very good idea, congrats 👏 !

I have a few more questions, before I set this up on my projects:

  • Is there a way to override the configuration files that will be installed?
  • Are all the configuration files supported, is it generic?

Once again, this is really cool. It replaces the need (for me) to setup lerna for my projects, it's minimalistic, waaay simpler and lightweight.

@epszaw
Copy link
Member

epszaw commented Aug 16, 2019

Hello, @pirix-gh! Thank you for your reply, it's very important for me :)
So, now I working on the new core logic, you can read thoughts about in #47. It should solve problem with some issues related to invalid merging. But as regards files overriding – no, sharec does not do that on the current state. It is not very difficult imo and we can do that with additional option for install command. For example: sharec install – will merge and copy files, but sharec install -f – override existing files without merge. What do you think?
Now, sharec supports all .json and .yml files, but for some tool it has special strategies, among them: eslint, babel, yaspeller. It the first future (of course after logic redesign 😉) I want to implement #57 and #56.
You can propose config what you need in issues.
Have a nice day! 🙌

@epszaw epszaw added core Issues related only for sharec core logic enhancement New feature or request labels Aug 16, 2019
@millsp millsp closed this as completed Aug 27, 2019
@epszaw epszaw mentioned this issue Sep 18, 2019
epszaw pushed a commit that referenced this issue Sep 21, 2019
epszaw pushed a commit that referenced this issue Sep 21, 2019
@epszaw
Copy link
Member

epszaw commented Sep 21, 2019

Hey, @pirix-gh! Overwrite mode was implemented by me in commits below.
It should be available in the next release 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues related only for sharec core logic enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants