New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaner admin/settings path #1839

Merged

rap1ds merged 2 commits into master from admin-settings-path

Mar 23, 2016

Member

rap1ds commented Mar 22, 2016

Use /admin/settings path instead of admin/communities/1234/settings

Add the new paths, using the non-resourceful routes (they are easier to read and understand)
Add redirection from old URL to new URL
Change the path name from settings_admin_community_path to admin_settings_path. Also, generating the path doesn't require @current_community parameter anymore, because the community ID is not part of the URL.


          Cleaner admin/settings path

f0a51a0

rap1ds added the pending review label

Contributor

mporkola commented Mar 22, 2016

The code looks fine, so in case you tested that the routing actually works it's ok for me _b

mporkola added review ok and removed pending review labels


          CHANGELOG [skip ci]

c9d6942

rap1ds merged commit cbca661 into master

rap1ds deleted the admin-settings-path branch

March 23, 2016 07:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels