Skip to content

Commit

Permalink
[M71] Revert "[M71] Revert "Fix the timezone detection on Windows wit…
Browse files Browse the repository at this point in the history
…h RDP.""

This reverts commit 751b643, which reverted the following earlier commit
(ccad447) to deal with a regression on Windows 7 timezone detection.
(https://crbug.com/913298)

This CL will reintroduce the change made in ccad447 for bug 854387 to
M71 branch and be followed by the proper fix for bug 913298.

> Fix the timezone detection on Windows with RDP.
>
> This is to cherry-pick fixes from the upstream to fix
> the timezone detection issue when a remote Windows
> session is used. The detected timezone should be that of
> a remote machine Chrome is running on, but without this
> fix, it uses the timezone of machine where a RDP connection
> originates.
>
> Bugs:
>
> https://unicode-org.atlassian.net/browse/ICU-13842
> https://unicode-org.atlassian.net/browse/ICU-13827
>
> Fixes (included in the upstream ICU 63 release candidate)
> unicode-org/icu#55
> unicode-org/icu#129
>
> TBR=yangguo@chromium.org
> Bug: 854387
> Test: Manual. See the bug
> Change-Id: Ic21e82987c1569e107d9b5e17bdc0d21e65fda3c
> Reviewed-on: https://chromium-review.googlesource.com/c/1270635

Bug: 854387, 913298
Test: Manual. See the bug
  • Loading branch information
jungshik committed Dec 17, 2018
1 parent 751b643 commit 0cc95d2
Show file tree
Hide file tree
Showing 5 changed files with 611 additions and 377 deletions.
12 changes: 11 additions & 1 deletion README.chromium
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,17 @@ D. Local Modifications
https://unicode-org.atlassian.net/browse/ICU-20140
- fix: https://github.com/unicode-org/icu/pull/136

15. Align memory buffer used in UnicodeSet on ARM.
15. Cherry pick an upstream patch for Windows timezone detection

- patches/wintz_detection.patch
- upstream bugs:
https://unicode-org.atlassian.net/browse/ICU-13842
https://unicode-org.atlassian.net/browse/ICU-13827
- fixes:
https://github.com/unicode-org/icu/pull/55
https://github.com/unicode-org/icu/pull/129

16. Align memory buffer used in UnicodeSet on ARM.

- patches/arm_align.patch
- upstream bug:
Expand Down
Loading

0 comments on commit 0cc95d2

Please sign in to comment.