ICU-13827 Clean up ICU4C "wintz.cpp" time zone detection code. #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefgen
changed the title
mingyzha
reviewed
Sep 17, 2018
| } | ||
|
|
||
| ures_close(bundle); |
There was a problem hiding this comment.
Don't we need to close the new bundle pointer?
There was a problem hiding this comment.
That is the neat thing about LocalUResourceBundlePointer, it will automatically call ures_close when the object goes out of scope. So we don't have to worry about remembering to call close. :)
mingyzha
approved these changes
Sep 17, 2018
yumaoka
approved these changes
Sep 18, 2018
sharing-sense
pushed a commit
to sharing-sense/chromium-deps-icu
that referenced
this pull request
Mar 13, 2019
This reverts commit ccad447 in M71 branch. There's an issue with DST detection so that we revert it in M71 branch. For M72 or later, we'll find a better fix. > Fix the timezone detection on Windows with RDP. > > This is to cherry-pick fixes from the upstream to fix > the timezone detection issue when a remote Windows > session is used. The detected timezone should be that of > a remote machine Chrome is running on, but without this > fix, it uses the timezone of machine where a RDP connection > originates. > > Bugs: > > https://unicode-org.atlassian.net/browse/ICU-13842 > https://unicode-org.atlassian.net/browse/ICU-13827 > > Fixes (included in the upstream ICU 63 release candidate) > unicode-org/icu#55 > unicode-org/icu#129 > > TBR=yangguo@chromium.org > Bug: 854387 > Test: Manual. See the bug > Change-Id: Ic21e82987c1569e107d9b5e17bdc0d21e65fda3c > Reviewed-on: https://chromium-review.googlesource.com/c/1270635 Bug: 854387, 913298
sharing-sense
pushed a commit
to sharing-sense/chromium-deps-icu
that referenced
this pull request
Mar 13, 2019
…h RDP."" This reverts commit 751b643, which reverted the following earlier commit (ccad447) to deal with a regression on Windows 7 timezone detection. (https://crbug.com/913298) This CL will reintroduce the change made in ccad447 for bug 854387 to M71 branch and be followed by the proper fix for bug 913298. > Fix the timezone detection on Windows with RDP. > > This is to cherry-pick fixes from the upstream to fix > the timezone detection issue when a remote Windows > session is used. The detected timezone should be that of > a remote machine Chrome is running on, but without this > fix, it uses the timezone of machine where a RDP connection > originates. > > Bugs: > > https://unicode-org.atlassian.net/browse/ICU-13842 > https://unicode-org.atlassian.net/browse/ICU-13827 > > Fixes (included in the upstream ICU 63 release candidate) > unicode-org/icu#55 > unicode-org/icu#129 > > TBR=yangguo@chromium.org > Bug: 854387 > Test: Manual. See the bug > Change-Id: Ic21e82987c1569e107d9b5e17bdc0d21e65fda3c > Reviewed-on: https://chromium-review.googlesource.com/c/1270635 Bug: 854387, 913298 Test: Manual. See the bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist