Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvements #1211

Closed
5 tasks done
sharkdp opened this issue Oct 3, 2020 · 7 comments
Closed
5 tasks done

Documentation improvements #1211

sharkdp opened this issue Oct 3, 2020 · 7 comments
Labels
Milestone

Comments

@sharkdp
Copy link
Owner

sharkdp commented Oct 3, 2020

With all the recent news about Hacktoberfest I thought it would be a good idea to point out good beginner issues that would be actually helpful for bat. In the past years, I have actually experienced Hacktoberfest as a really great event - both as a contributor as well as a maintainer.

One thing that I would like to focus on for the next bat release is documentation. This includes the README, the man page as well as the bat -h and bat --help texts. It also includes documentation for contributors/developers like the issue templates.

In my mind, excellent documentation is something that separates good projects from really great ones. A lot of the issues that are opened in the bat repository could have been prevented if the documentation would have been clearer. And for each such issue, there are probably several more users that are already too frustrated with the tool and don't even bother opening a ticket on GitHub.

We can list potential TODOs here, but there is also a list of open issues that deal with documentation which an be found here:

List of documentation-labeled issues.

Apart from that, a few things that come to my mind:

  • I think we should merge the assets/README.md file into the main README.md or maybe link to it from the main README. In general, the whole process around contributing new syntaxes (or themes) should be described in detail. Note that there is some information regarding this (policies) in the issue templates as well.
  • For contributors, we should clearly document that they should please update the CHANGELOG.md file as well. This makes the release of new bat versions much easier.
  • The short bat -h text should refer to the longer and more detailed bat --help text (and vice versa). See my fd project as an example for how this can be done with clap.
  • Add the step-by-step guide from Complete collection of syntax highlighting test files #1213 to https://github.com/sharkdp/bat/blob/master/doc/assets.md as a requirement for the addition of new syntaxes.
  • Update the man page to be up-to-date with the --help text.

If you have ideas on how to improve the documentation, please post them here or open a new issue if it's a larger scale change.

@trncb
Copy link
Contributor

trncb commented Oct 7, 2020

@sharkdp if no-one has taken it, I can find a way to integrate assets/README.md into README.md

@sharkdp
Copy link
Owner Author

sharkdp commented Oct 7, 2020

@sharkdp if no-one has taken it one, I can find a way to integrate assets/README.md into README.md

I don't think anyone has 👍. I think it would be best to move assets/README.md to doc/assets.md and then write a short section in the README.md that links to this document. It might also be a good idea to review assets.md for possible improvements/updates.

Later, I would also like to extend doc/assets.md to describe the whole process of getting a new syntax accepted in bat (including the policies, for example: #1262).

@trncb
Copy link
Contributor

trncb commented Oct 7, 2020

Good thinking. I'll take a stab at it.

@asamant
Copy link

asamant commented Oct 9, 2020

@sharkdp Having a CONTRIBUTING.md file with instructions for new developers would be of much help to address the issue regarding the CHANGELOG.md file update. So the README.md file can be from a user's perspective and the CONTRIBUTING.md file from a developer's. Thoughts on this?

@sharkdp
Copy link
Owner Author

sharkdp commented Oct 9, 2020

@asamant Yes - absolutely. We are planning to create a CONTRIBUTING.md file soon that would have this changelog step as one of the main entries.

adrian-rivera added a commit to adrian-rivera/bat that referenced this issue Oct 27, 2020
This changes the README file and adds a new section `Contributors`.
This section includes instructions to remind contributors to make an
update to the changelog.
adrian-rivera added a commit to adrian-rivera/bat that referenced this issue Oct 27, 2020
This changes the README file and adds a new section `Contributors`.
This section includes instructions to remind contributors to make an
update to the changelog.
@adrian-rivera
Copy link
Contributor

I added a new section Contributors on README to address the missing item on the TODO, please take a look!

sharkdp pushed a commit that referenced this issue Oct 29, 2020
This changes the README file and adds a new section `Contributors`.
This section includes instructions to remind contributors to make an
update to the changelog.
@sharkdp sharkdp added this to the v0.18.0 milestone Jan 9, 2021
@sharkdp sharkdp mentioned this issue Jan 9, 2021
@sharkdp
Copy link
Owner Author

sharkdp commented Jan 10, 2021

Closing this for now, as all tasks have been resolved and the remaining documentation tickets are tracked in the v0.18 milestone.

@sharkdp sharkdp closed this as completed Jan 10, 2021
@sharkdp sharkdp unpinned this issue Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants