Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax highlighting tests for VimL #1450

Merged
merged 4 commits into from
Dec 28, 2020

Conversation

esensar
Copy link
Contributor

@esensar esensar commented Dec 27, 2020

Adds a syntax highlighting test for VimL
with source file based on parts of my own configuration
changed to cover as much of syntax as possible.

NOTES:
Last line of source (syntax enable) does not get highlighted,
since syntax keyword is not part of highlighting rules.

Related to #1213

Adds a syntax highlighting test for VimL
with source file based on parts of my own configuration
changed to cover as much of syntax as possible.

**NOTES:**
Last line of source (`syntax enable`) does not get highlighted,
since `syntax` keyword is not part of highlighting rules.

Related to sharkdp#1213
@esensar
Copy link
Contributor Author

esensar commented Dec 27, 2020

I have noticed #1064.
I will update files to also include case from this, but this means that generated highlight is actually invalid.

**NOTES:**
- PR is not yet merged in upstream repository (SalGnt/Sublime-VimL#12),
but sublime-syntax file is already updated with changes.
- Updated syntax test files are added as well

This fixes sharkdp#1064
@esensar
Copy link
Contributor Author

esensar commented Dec 27, 2020

Adding a comment too for visibility:

This fixes #1064

@sharkdp
Copy link
Owner

sharkdp commented Dec 28, 2020

Awesome - thank you very much!

@sharkdp sharkdp merged commit 9c9a9ac into sharkdp:master Dec 28, 2020
@esensar esensar deleted the syntax-test/viml branch December 28, 2020 08:35
@sharkdp
Copy link
Owner

sharkdp commented Feb 28, 2021

Bugfix released in bat v0.18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants