Improve Syslog and general log file highlighting #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
eth-p
approved these changes
Apr 4, 2021
fort068fibl
approved these changes
Apr 9, 2021
keith-hall
changed the title
|
Thank you, this looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the Syslog dependency with a custom syntax definition and add a syntax definition for highlighting general log files. Fixes #1605
Note: sublimehq/Packages#1036 (comment) isn't officially standardised yet, so we might need to update the color schemes we use to cater for the
markup.errorandmarkup.warningscopes, potentially just by covering them in the existinginvalid.illegalandinvalid.deprecatedrules (which I've done for Monokai by updating the patch) ... But, the good news is that the LSP plugin for Sublime Text is making use of them already, so many actively maintained color schemes likely should already highlight them or will soon if they don't already. :)