Add support for BusyBox less as pager #2162
Conversation
|
Looks good to me, but my Rust code reviews are lackluster compared to those of our other maintainers, so let's see what they say :) I think to fix CI after unmarking the PR as a draft, you just need to execute |
There was a problem hiding this comment.
Thanks a lot for working on this! This is a very good start. I added some comments. For the record, this PR does not change the public API of bat-as-a-library, so we don't need to be super picky about naming of things:
% pr=2162; git fetch -f upstream pull/$pr/head:$pr && git checkout $pr
% cargo install cargo-public-api
% cargo public-api --diff-git-checkouts origin/master 2162
Removed items from the public API
=================================
(none)
Changed items in the public API
===============================
(none)
Added items to the public API
=============================
(none)
Also add an entry to CHANGELOG.md please 🙏 Edit: I see now that you already mentioned you would do that.
* Revert all changes in `test` directory * Minimize overall diff size * Detect busybox from separate helper function * Pass equivalent options to BusyBox from same code by changing from long to short options
Add test for invalid utf-8 Add `parse_less_version_busybox` to test for invalid program Add commenting around short options
|
Many thanks for working with me on this. It was a good learning experience. |
|
Let's go ahead and merge this now since both me and Keith has Approved |
See issue #2143
This is an initial working draft. I haven't updated the CHANGELOG, but will before merge if accepted.