Map fish_history to YAML
#2237
Merged
Map fish_history to YAML
#2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-hall
approved these changes
Jul 5, 2022
Enselic
reviewed
Aug 12, 2022
| @@ -0,0 +1,11 @@ | |||
| [38;2;248;248;242m-[0m[38;2;248;248;242m [0m[38;2;249;38;114mcmd[0m[38;2;248;248;242m:[0m[38;2;248;248;242m [0m[38;2;230;219;116mecho "hello world"[0m | |||
There was a problem hiding this comment.
Thank you for taking the time to open a PR!
I'm a bit confused, because this file looks very gray and not very YAML-y. Do you see what I see or am I doing something wrong?
There was a problem hiding this comment.
curl -q https://raw.githubusercontent.com/sharkdp/bat/1e1fa7cde5c973ea42c97ea18479d1b0b1d3d4a0/tests/syntax-tests/highlighted/fish_history/fish_history
Enselic
added
the
waiting-on-author
sharkdp
removed
the
waiting-on-author
sharkdp
approved these changes
Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to fish-shell/fish-shell#6493, fish history file
fish_historyis loosely based on YAML. While it is not something often inspected, it would be nice to have correct highlighting out of the box.