Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bash completion improvements #2310

Merged
merged 6 commits into from
Sep 11, 2022
Merged

bash completion improvements #2310

merged 6 commits into from
Sep 11, 2022

Commits on Sep 10, 2022

  1. Split bash completion option lists over multiple lines, sync sort wit… 

    …h --help

For maintainability/diffability.
    @scop
    scop committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    64995d7 View commit details
    Browse the repository at this point in the history

  2. Add --acknowledgements and --ignored-suffix to bash completion

    @scop
    scop committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    e463d72 View commit details
    Browse the repository at this point in the history

  3. Do not offer bash filename completions with --list-languages/-themes

    @scop
    scop committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    e66a1d5 View commit details
    Browse the repository at this point in the history

  4. Add --style argument bash completion

    @scop
    scop committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    3338790 View commit details
    Browse the repository at this point in the history

  5. Exclude --unbuffered from bash completions 

    It's a no-op, so there's little reason to suggest it.
    @scop
    scop committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    1199895 View commit details
    Browse the repository at this point in the history

  6. Improve bash completion escaping 

    `compopt -o filenames` is a cheap way to accomplish mostly wanted
behavior. However it is semantically incorrect when we are not actually
completing filenames, and has side effects -- for example adds a
trailing slash to candidates matching present dirs.

bash >= 4.1 can `printf -v` to an array index, use it instead where
available.
    @scop
    scop committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    3ba9fb8 View commit details
    Browse the repository at this point in the history