Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customizing output directory for generated assets #2515

Merged
merged 2 commits into from
Mar 25, 2023
Merged

Allow customizing output directory for generated assets #2515

merged 2 commits into from
Mar 25, 2023

Conversation

tranzystorekk
Copy link
Contributor

Makes packaging easier, e.g. by doing export BAT_ASSETS_GEN_DIR=${PWD}/gen instead of looking in the target dir.

@sharkdp
Copy link
Owner

sharkdp commented Mar 25, 2023

But... you can already do that using OUT_DIR, no?

@tranzystorekk
Copy link
Contributor Author

Not really, that's an env var that cargo sets for the build script, overwriting anything from the current shell

@sharkdp
Copy link
Owner

sharkdp commented Mar 25, 2023

Ah, right. Thank you for the clarification. In that case, this looks good.

@sharkdp sharkdp merged commit 1712ec9 into sharkdp:master Mar 25, 2023
@tranzystorekk tranzystorekk deleted the custom-asset-gen-dir branch March 25, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tranzystorekk @sharkdp