Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the is-terminal crate instead of atty #2530

Merged
merged 1 commit into from Apr 5, 2023
Merged

Use the is-terminal crate instead of atty #2530

merged 1 commit into from Apr 5, 2023
+6 −6

Conversation

nickelc
Copy link
Contributor

@nickelc nickelc commented Apr 5, 2023 •
edited

The crate is already used by clap and a similar trait is about to be stabilized in std.

https://doc.rust-lang.org/stable/std/io/trait.IsTerminal.html

@nickelc
Use the is-terminal crate instead of atty
57cc0d8 
The crate is already used by `clap` and a similar trait is about to be
stabilized in `std`.
Enselic
Enselic approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@Enselic Enselic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sharkdp sharkdp merged commit c5731b9 into sharkdp:master Apr 5, 2023
18 checks passed
@sharkdp
Copy link
Owner

sharkdp commented Apr 5, 2023

Thank you

@nickelc nickelc deleted the deps/use_is_terminal branch April 5, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enselic Enselic Enselic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nickelc @sharkdp @Enselic