Replace nu-ansi-term with anstyle crates

[nickelc]

The nu-ansi-term crate can now be replaced by the anstyle crates which are used by clap for its ANSI text styling.

[nickelc]

So, I looked into the failing regression tests and the difference is that anstyle writes the effects for bold, italic etc. separately.

playground

[sharkdp]

Thank you and sorry for the review delay. Can you please go into more details why this is necessary/beneficial?

[Enselic]

I think the benefit is that we get rid of a dependency (nu-ansi-term) without adding any new ones, since the "new" ones are already needed by clap?

[Enselic]

This looks good to me. The ANSI color diffs all seem to be only differences in how the colors are encoded, not how they are displayed (at least in my terminal I did not see any actual color change).

Maybe there is a mistake among all those lines. That can be fixed with a follow up PR if needed. When I glance it over the code changes slowly it all looks reasonable to me.

Can you rebase this on latest master please?

[sharkdp]

So, I looked into the failing regression tests and the difference is that anstyle writes the effects for bold, italic etc. separately.

This could have adverse effects though, right? We need to write more output. And terminal emulators might take a longer time to parse the input and/or to set up the proper style.

I would appreciate if we could run a benchmark to see that this doesn't have any negative effects. Since we want to include possible effects of the terminal emulator, we can use hyperfines --show-output option.

Let's run performance checks first

[Enselic]

Good point about performance. I didn't think about that. Let's see some numbers before we merge.

[Enselic]

Closing for now to keep the PR inbox clean. Of course feel free to re-open if you resume work on this!