Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NSIS support #2577

Merged
merged 4 commits into from Sep 1, 2023
Merged

add NSIS support #2577

merged 4 commits into from Sep 1, 2023

Conversation

idleberg
Copy link
Contributor

@idleberg idleberg commented May 28, 2023

NSIS is a scripting language to create installers for Windows applications. It has been around for a very long time and still has a wide user base. I'm a frequent contributor to the submodule added in this PR and would love to see it supported by bat.

@keith-hall
Copy link
Collaborator

It looks like https://packagecontrol.io/packages/NSIS meets our criteria of download count for inclusion, so no objections here.

Please add an example NSIS file to the https://github.com/sharkdp/bat/tree/master/tests/syntax-tests/source folder, and run the update.sh script in the folder above to generate the highlighted file and then add them both to this PR. This allows us to more easily track regressions when color schemes change, or the syntax highlighting library we used is updated etc.

@idleberg
Copy link
Contributor Author

@keith-hall Added the files. Any idea why the generated file doesn't highlight? The highlighter works fine in Sublime Text versions 3 and 4.

@keith-hall
Copy link
Collaborator

If I understand correctly, the highlighting didn't work for you locally - it seems CI highlights it fine and that's why it complains about the difference between the "expected" highlighted file which is included in this PR, which seems to have only one color.
Maybe try running step 3 from https://github.com/sharkdp/bat/blob/master/doc/assets.md#adding-new-builtin-languages-for-syntax-highlighting again and see if it helps.

@idleberg
Copy link
Contributor Author

idleberg commented Jun 2, 2023

@keith-hall I don't know why the automatically generated file continues to be all gray, but I did manual adjustments and now the test runs through. I'm not happy with this process, but this should be sufficient to test possible future regressions.

@Enselic Enselic merged commit 32c0e1f into sharkdp:master Sep 1, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants