Enable bat to find more binary on Windows
#2580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enselic
reviewed
Jun 1, 2023
On Windows, `more` is a COM executable (i.e. its extension is `com`). As `resolve_binary()` previously tried to emulate the behaviour of Win32 API's `CreateProcess()`, it would search for `more.exe` and fail.
mataha
commented
Jul 18, 2023
|
Closing in favor of #2651. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows,
moreis a COM executable (i.e. its extension iscom). Asresolve_binary()tries to emulate the behaviour of Win32 API'sCreateProcess(), it will search formore.exeand fail. This commit adds an exception to that by specifying the pager's binary explicitly.Fixes #2570. See also BurntSushi/ripgrep#2523.
I'd like to add that
moreis not as bad as README makes it to be - it does support colors: