Rework lessopen
implementation to use execute
crate instead of run_script
#2805
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced the
lessopen
implementation to use a crate calledexecute
instead of the currently-usedrun_script
. This has the benefit of simplifying the code a little, but more importantly fixes a few weird issues I noticed.The issues I noticed that these changes fix are:
batpipe
not working right when usingfish
as a shell. Currently,bat
shows the commands thatbatpipe
prints to configure$LESSOPEN
when you evaluate it in your startup config rather than the preprocessed file output.bat
not showing any output at all when usingglow
to preprocess markdown files.