Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch the lisp syntax #2970

Merged
merged 4 commits into from
May 31, 2024
Merged

Patch the lisp syntax #2970

merged 4 commits into from
May 31, 2024

Conversation

ccqpein
Copy link
Contributor

@ccqpein ccqpein commented May 27, 2024

The potential solution of the issue #2969.

I am not sure if it is the right way to update syntax of bat, and it is my first git patch. Feel free to change anything.

Thanks

@keith-hall
Copy link
Collaborator

this looks okay to me, this sublime-syntax doesn't seem to use any more recent features which the syntax highlighting engine syntect doesn't support yet.
In order to get the CI step to pass, you'll need to update the "highlighted file" - see https://github.com/sharkdp/bat/blob/master/doc/assets.md#syntax-tests. I would also recommend including some code in the "source file" which this upgrade solves highlighting for, like you mentioned (defun test () :a-from-b)

@ccqpein
Copy link
Contributor Author

ccqpein commented May 29, 2024

Sure, let me check the test file.

PS: I think I don't need to add this code snippet as the new test. Because the current test sets already show the issue (except it is -test- rather than the -from-).

Screenshot 2024-05-28 at 21 05 17

@keith-hall keith-hall merged commit 3407bf4 into sharkdp:master May 31, 2024
23 checks passed
@keith-hall
Copy link
Collaborator

Thanks for your contribution 🙂

@ccqpein
Copy link
Contributor Author

ccqpein commented May 31, 2024

@keith-hall no problem. Thanks for your project maintaining too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants