Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add padding above headers when no grid #981

Merged
merged 3 commits into from May 12, 2020
Merged

Add padding above headers when no grid #981

merged 3 commits into from May 12, 2020

Conversation

pt2121
Copy link
Contributor

@pt2121 pt2121 commented May 11, 2020 •
edited

closes #968

@pt2121 pt2121 force-pushed the pt/padding-header branch 2 times, most recently from d33f2a2 to 188b79a Compare May 11, 2020 15:06
@sharkdp
Copy link
Owner

sharkdp commented May 11, 2020 •
edited

Thank you for your contribution!

I would definitely prefer a version which would not add the blank line before the first file. We should probably also add a new test that verifies that this works as expected.

@pt2121
Copy link
Contributor Author

pt2121 commented May 11, 2020

Gotcha. I will update my PR. Thanks for the feedback.

@pt2121 pt2121 marked this pull request as draft May 12, 2020 02:29
@sharkdp
Copy link
Owner

sharkdp commented May 12, 2020

Thank you for the updates. Note that we only want to show the padding if the header style component is enabled. We do not want to add padding otherwise.

sharkdp
sharkdp approved these changes May 12, 2020
View reviewed changes
Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update! The changes look good.

Could you please add an entry to the "unreleased" section in the CHANGELOG.md? Under "Features" or "Other". The format for entries is:

- Description what has been changed, see #123 (@user)

where #123 links to the bug ticket and/or this PR and user is your username.

Thank you!

@pt2121 pt2121 marked this pull request as ready for review May 12, 2020 14:25
@sharkdp sharkdp merged commit 491a5a1 into sharkdp:master May 12, 2020
@sharkdp sharkdp mentioned this pull request May 12, 2020
Closed
@pt2121
Copy link
Contributor Author

pt2121 commented May 12, 2020

Thanks again for quick responses. 👍

@pt2121 pt2121 deleted the pt/padding-header branch May 12, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkdp sharkdp sharkdp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extra [vertical] padding around headers when no grid
2 participants
@pt2121 @sharkdp