Skip to content

Commit

Permalink
Upgrade minimum reqiured version of Rust to 1.29
Browse files Browse the repository at this point in the history
This upgrades the minimum required version of Rust to 1.29 in order to
fix #288.

See also:
- Rust compiler bug ticket: rust-lang/rust#50619
- Rust compiler PR with the fix: rust-lang/rust#50630

closes #288
  • Loading branch information
sharkdp committed Sep 18, 2018
1 parent 8fb25f1 commit 53226f8
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 10 deletions.
10 changes: 5 additions & 5 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,19 +64,19 @@ matrix:

# Minimum Rust supported channel.
- os: linux
rust: 1.20.0
rust: 1.29.0
env: TARGET=x86_64-unknown-linux-gnu
- os: linux
rust: 1.20.0
rust: 1.29.0
env: TARGET=x86_64-unknown-linux-musl
- os: linux
rust: 1.20.0
rust: 1.29.0
env: TARGET=i686-unknown-linux-gnu
- os: linux
rust: 1.20.0
rust: 1.29.0
env: TARGET=i686-unknown-linux-musl
- os: osx
rust: 1.20.0
rust: 1.29.0
env: TARGET=x86_64-apple-darwin

# Code formatting check
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ With Rust's package manager [cargo](https://github.com/rust-lang/cargo), you can
```
cargo install fd-find
```
Note that rust version *1.20.0* or later is required.
Note that rust version *1.29.0* or later is required.

### From binaries

Expand Down
7 changes: 3 additions & 4 deletions build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,11 @@ use std::process::exit;
include!("src/app.rs");

fn main() {
match version_check::is_min_version("1.20") {
// rustc >= 1.20
match version_check::is_min_version("1.29") {
Some((true, _)) => {}
// rustc < 1.20 or can't figure it out
// rustc version too small or can't figure it out
_ => {
writeln!(&mut io::stderr(), "This crate requires rustc >= 1.20").unwrap();
writeln!(&mut io::stderr(), "'fd' requires rustc >= 1.29").unwrap();
exit(1);
}
}
Expand Down

0 comments on commit 53226f8

Please sign in to comment.