-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The benchmarks are misleading #31
Comments
Unfortunately, neither your comment nor the README provide a way to easily run and confirm the benchmark for yourself, so it's pretty hard to make any kind of progress. I'd encourage you to experiment with disabling |
Writing to
--
|
Also, the README's benchmark is clearly running with different flags than what you've provided. :-) |
I agree but it implies that the search in general is faster(also mentions that it is fair). |
@lilianmoraru Did you experiment with the |
No difference(This source code does not have .gitignore):
|
I think @lilianmoraru and @sharkdp need to focus on finding a common set of files that they can each benchmark and verify. There are too many variables at play to immediately blame the regex engine. @lilianmoraru Even in your own benchmark |
If I use "-n" it has almost the same performance characteristics as |
I think you are right, it seems like the
I think this will really depend on the specific situtation, as @BurntSushi mentioned:
Absolutely. I honestly did not expect this to become this popular that fast, so the current benchmark was really just a first shot in order for me to get a feeling about the performance.
Yes, please pipe the output to
The README says: "The given options for fd are needed for a fair comparison". The options are
Coming back to your original point, you are right in that
Agreed. I suggest the following:
As a first version of a reproducible benchmark (suggesting that
|
Btw, if you want to bench the Rust code(and use the nightly Side-note: |
Also, consider adding a larger repository to your benchmark. :-) A couple dozen milliseconds is frighteningly fast---probably in "process overhead" territory. (Of course, that is also important to benchmark!) |
It seems that it is enough to make the regex a bit more complicated and
|
Yes, thanks. It looks like those results are similar for larger folders, though ( |
@sharkdp Well, I came to the conclusion that it actually performs pretty darn well. |
The |
Just in case anyone comes back to this ticket: This all happened before parallel search was implemented (#41). |
I think that the README should specifically mention that the regex search is faster(that's because the regex is slow in
find
).The actual search is slower(it seems to imply that the find in general is faster).
Here is a more realistic usage of
find
, on an SSD(all runs are on warm cache):And because
fd
uses patterns, it would look like this:Weird, I just tested(while writing this) with
-iregex
and I got this:The text was updated successfully, but these errors were encountered: