Invalid option values are silently ignored

[reima]

Describe the bug you encountered:
When supplying an invalid value to an option that expects a numeric value, fd silently ignores that option.

For example, fd --max-depth x silently ignores the --max-depth option.

At least the following options are affected:

• --min-depth
• --max-depth (--maxdepth)
• --exact-depth
• --threads
• --max-buffer-time
• --max-results

Describe what you expected to happen:
I expected fd to exit with an error message saying the option value is invalid.

What version of fd are you using?
fd 8.1.1

Which operating system / distribution are you on?
Windows 10 (Version 2004, Build 19041.572)

[sharkdp]

Thank you very much for reporting this. That should definitely be fixed.

I actually made a similar change to my hyperfine program recently (sharkdp/hyperfine#338), which suffered from a similar problem.

[sharkdp]

Should be fixed in #676:

▶ fd --max-depth x          
[fd error]: Failed to parse argument to --max-depth/--exact-depth: invalid digit found in string

▶ fd --max-depth ''
[fd error]: Failed to parse argument to --max-depth/--exact-depth: cannot parse integer from empty string

▶ fd --threads=a   
[fd error]: Failed to parse number of threads: invalid digit found in string

▶ fd --threads=0
[fd error]: Number of threads must be positive.

[sharkdp]

fix released in v8.2.0.