[BUG] ~/.ignore & ~/.fdignore are not respected

[ahmedelgabri]

(Bug template gave me 400 a couple of times, that's why I didn't use it)

~/.ignore & ~/.fdignore are not respected

echo .git > ~/.ignore # or ~/.fdignore
cd ~/repo
fd --hidden --no-ignore-vcs # will show .git in the results

while works with ~/.config/fd/ignore

mkdir -p ~/.config/fd
echo .git > ~/.config/fd/ignore
cd ~/repo
fd --hidden --no-ignore-vcs # will NOT show .git in the results

fd 8.3.0 on macOS Monterey 12.0.1

[tavianator]

Is ~/.ignore or ~/.fdignore documented? As far as I can tell, only ~/.config/fd/ignore is documented to apply globally.

[ahmedelgabri]

@tavianator

From this comment #485 by @sharkdp

A .fdignore or .ignore file will always just affect directories below it (just like .gitignore files).

So, technically if I have ~/.ignore or ~/.fdignore it should work, and it was working like that.

I'm fine if the behaviour changed now, but at least document that or explicitly mention how it works now. Because I was surprised when I started to see .git & node_modules popping up in my search.

[tavianator]

Ohh right I see. ~/.ignore/~/.fdignore are not global ignore files but they ought to apply to your whole home directory, including ~/repo. And indeed they do in my testing, but --no-ignore-vcs breaks it.

This was broken by f8ae334, aka #817. This snippet turns off read_parent_ignore a little too aggressively.

[phongnh]

Same problem on my side for fd 8.3. I use fd for vim fuzzy finder plugins. In my case I don't use .gitignore in project because it ignores config files that I needed like config/database.yml in Rails project. Instead, I use .ignore (.fdignore) at parent dir to ignore custom files that I never open. For example:

$ tree -L 1 ~/projects/
.
├── rails-app1
└── rails-app2

# ~/projects/.ignore
vendor/
*.scss
*.js

Maybe the flag --no-ignore-parent should not go along with --no-ignore-vcs?

I tried to build fd from source with this check removed, it works for my case.

[sharkdp]

Fixed in https://github.com/sharkdp/fd/releases/tag/v8.3.1

[towry]

NOTE:

If the current directory includes a .ignore file, the ~/.ignore file will not have any impact.