Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a simple test for executable files #1183

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

Ptipiak
Copy link
Contributor

@Ptipiak Ptipiak commented Nov 24, 2022

resolve #1106 close #1106

@Ptipiak
Copy link
Contributor Author

Ptipiak commented Nov 24, 2022

The nix package offer function to change a file chmod, but I though this simple test could do the job.
The test make sure the file with chmod 005 doesn't appear in the result set.
Let me know if it's enough or if it would be better to actually make two assertion to test if the file appear/disappear from the result set after it's chmod as been changed.

tests/tests.rs Outdated Show resolved Hide resolved
@Ptipiak Ptipiak force-pushed the integration-test-files-permission branch from f4304aa to cd5fad3 Compare November 26, 2022 09:10
@tmccombs tmccombs merged commit 2aa966c into sharkdp:master Nov 29, 2022
@Ptipiak Ptipiak deleted the integration-test-files-permission branch November 29, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

help: mention that fd detects executables by file permissions
2 participants