Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedoxOS support. #131

Merged
merged 2 commits into from
Oct 20, 2017
Merged

RedoxOS support. #131

merged 2 commits into from
Oct 20, 2017

Conversation

goyox86
Copy link
Contributor

@goyox86 goyox86 commented Oct 18, 2017

Just small tweaks to make it compile (and run) in RedoxOS!

Works like a charm BTW!

\o/

@sharkdp
Copy link
Owner

sharkdp commented Oct 19, 2017

Thank you very much for your contribution!

Do all test run on RedoxOS (cargo test)? I'm wondering because there are a few other places where we have conditionals like #[cfg(unix)].

@goyox86
Copy link
Contributor Author

goyox86 commented Oct 19, 2017

Thank you for the tool!

Basically we cannot run cargo test inside Redox yet. I basically ran a few manual tests inside Redox and everything seems to be working fine.

Regarding to the cfg uses I've checked and then_execute was the only one I saw with conditional compilation involving Redox I just removed Redox from the two conditionals and Now I think we are using the libstd version of then_execute which is fine as redox has full support. But I dunno I maybe wrong about that removal.

Also in the UNIX libc based version you were importing * from libc which is a lot hehe they thow everything in the root module.

Let me know if the patch still makes sense!

Regards!

@goyox86
Copy link
Contributor Author

goyox86 commented Oct 19, 2017

Ah BTW none of the other platforms seems to be broken with the patch I think we are safe merging, and I commit to continue iterating on the upcoming issues regarding Redox integration 😄

@sharkdp
Copy link
Owner

sharkdp commented Oct 20, 2017

@mmstick Would you mind taking a quick look at this since you initially introduced the redox conditionals?

@mmstick
Copy link
Contributor

mmstick commented Oct 20, 2017

Looks okay to me. Redox does have the syscalls needed to be optimized as the Unix platforms though. You just need to grab the same functions from redox_syscalls.

@sharkdp sharkdp merged commit 6dc704a into sharkdp:master Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants